Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code with std::unique_ptr #2643

Merged
merged 3 commits into from
May 27, 2023
Merged

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented May 26, 2023

This PR addresses #2616 using the appropriate C++ mechanisms.
Also some tidying.

@what-the-diff
Copy link

what-the-diff bot commented May 26, 2023

PR Summary

  • Memory management improvements
    Switch to using unique_ptr instead of raw pointers to prevent memory leaks and ease resource management.
  • Fix memory leaks in StreamTransformer.cpp
    Address memory leaks, enhancing application stability and performance.
  • Simplify and improve CommandOutput.cpp
    Replace a code segment with a more efficient and straightforward approach.
  • Refactor Basic_Audio sample application
    Incorporate smart pointers and reorganize some code segments for better code quality and memory safety.

@mikee47
Copy link
Contributor Author

mikee47 commented May 26, 2023

AI seems to like my PR. My life is complete.

@elfring
Copy link

elfring commented May 27, 2023

🔮 Can my code review comments matter any more here?

@mikee47 mikee47 deleted the fix/unique_ptr branch May 27, 2023 20:02
@mikee47
Copy link
Contributor Author

mikee47 commented May 27, 2023

crystal_ball Can my code review comments matter any more here?

Please feel free to comment, I can always open another PR :-)

@elfring
Copy link

elfring commented May 28, 2023

Please feel free to comment, …

I am still waiting on more constructive feedback for my previous two code review questions on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants