Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of std::iterator is deprecated #2642

Merged
merged 1 commit into from
May 26, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented May 25, 2023

This PR removes the use of std::iterator as it's deprecated in C++17.

@what-the-diff
Copy link

what-the-diff bot commented May 25, 2023

PR Summary

  • Update iterator category
    Change the iterator_category to std::forward_iterator_tag for better compatibility
  • Add type aliases
    Define iterator category, value type, difference type, and pointer/reference types using using statements
  • Remove redundant template
    Remove an unnecessary template parameter from IteratorTemplate class definition

@slaff slaff added this to the 5.0.0 milestone May 25, 2023
@slaff slaff merged commit 862bb32 into SmingHub:develop May 26, 2023
@mikee47 mikee47 deleted the fix/std-iterator-deprecated branch May 28, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants