Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SOC support checks #2610

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix SOC support checks #2610

merged 2 commits into from
Jan 31, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jan 30, 2023

Building for SMING_SOC=esp32 doesn't work as intended as 'findstring' will also match esp32c3, etc. Use 'filter' instead.

Remove the list of 'supported SOCs' from the 'unsupported SOC' message as this is often wrong. Use 'make list-soc' instead.

@what-the-diff
Copy link

what-the-diff bot commented Jan 30, 2023

  • The findstring function was replaced with the filter function.
  • Checksoc-print is now checksoc and it prints a different message if SMING_SOC isn't in PROJECT_SOC

@slaff slaff added this to the 4.8.0 milestone Jan 31, 2023
@slaff slaff merged commit ab016a8 into SmingHub:develop Jan 31, 2023
@mikee47 mikee47 deleted the fix/soc-support branch February 1, 2023 10:34
@slaff slaff mentioned this pull request Feb 8, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff