New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP2040 fix RTC get/set time methods #2609

Merged

slaff merged 1 commit into SmingHub:develop from mikee47:fix/rp2040-rtcgetset

Jan 30, 2023

Contributor

mikee47 commented Jan 30, 2023

Return 0 for current time if not initialised
Month is off by one, time setting fails


          RP2040 fix RTC get/set time methods

c9acac2

Return 0 for current time if not initialised
Month is off by one, time setting fails

what-the-diff bot commented Jan 30, 2023

The month is now 0-based instead of 1-based.
If rtc_get_datetime fails, it will return a zero timestamp (instead of the current time).

slaff added this to the 4.8.0 milestone

slaff added the 3.5 - Approved - Waiting for CI results label

slaff merged commit 61ee671 into SmingHub:develop

slaff removed the 3.5 - Approved - Waiting for CI results label

mikee47 deleted the fix/rp2040-rtcgetset branch

February 1, 2023 10:34

slaff mentioned this pull request

Preparation for Release 5.0 (was 4.8.0) #2597

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet