Fix IFS attribute copying and Access Control behaviours #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening on directory handle removed in SmingHub#2308
mikee47
changed the title
Fix `readdir()` not setting default ACL Translate 'NOENT' lfs error code into 'NotFound' IFS error Fix missing directory attribute in `fstat`
mikee47
force-pushed
the
fix/ifs-acls
branch
from
e14a691 to
f20c2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few problems related to handling of file/directory Access Control entries.
IFS
LittleFS
readdir()not setting default ACLAlso remove unused FileStream method. Opening on directory handle removed in #2308.