Fix CI library python requirements #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of missing `lxml` python requirement. This is defined in UPnP-Schemas but `make fetch` doesn't recurse dependencies. However, running `make submodules` from the project directory does fix the problem. Should have gone with that to start with!
Add `make submodules` as things could break there too. Merge make targets using %.built
mikee47
changed the title
|
test builds https://ci.appveyor.com/project/mikee47/HueEmulator/builds/42030672 This requires setting custom build yml to https://raw.githubusercontent.com/mikee47/Sming/fix/ci-lib/Tools/ci/library/appveyor.txt plus 2 environment overrides: |
|
@mikee47 are you ready with this PR? The CI tests have completed successfully. |
|
@slaff Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building HueEmulator library fails because of missing
lxmlpython requirement.This is defined in UPnP-Schemas but
make fetchdoesn't recurse dependencies.However, running
make submodulesfrom the project directory does fix the problem.Should have gone with that to start with!
Revise samples + component-samples build targets
Add
make submodulesas things could break there too.Merge make targets using %.built