Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs build #2394

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix readthedocs build #2394

merged 2 commits into from
Oct 18, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 16, 2021

Stopped working about a month ago!

Immediate problem appears to be funcparserlib.
See vlasovskikh/funcparserlib#70.

Found mr2r (mr2 is out of date) and can now use sphinx 4.

Also bullets missing e.g. on front page... updated theme to 1.0.0. seems to fix this.

Immediate problem appears to be `funcparserlib`.
See vlasovskikh/funcparserlib#70.

Found mr2r (mr2 is out of date) and can now use sphinx 4.
@mikee47 mikee47 changed the title Build is broken, update everything readthedocs build is broken, update everything Oct 16, 2021
@mikee47
Copy link
Contributor Author

mikee47 commented Oct 16, 2021

Have checked this at https://smingdev.readthedocs.io/en/fix-read-the-docs/

@mikee47 mikee47 changed the title readthedocs build is broken, update everything Fix readthedocs build Oct 17, 2021
@slaff slaff added this to the 4.5.0 milestone Oct 18, 2021
@slaff
Copy link
Contributor

slaff commented Oct 18, 2021

@mikee47 thank you for fixing this!

@slaff slaff merged commit a817021 into SmingHub:develop Oct 18, 2021
@mikee47 mikee47 deleted the fix/read-the-docs branch October 18, 2021 20:42
@mikee47
Copy link
Contributor Author

mikee47 commented Oct 18, 2021

@slaff Is there any way to backport this PR to the 4.4.0 release?

@slaff
Copy link
Contributor

slaff commented Oct 19, 2021

Is there any way to backport this PR to the 4.4.0 release?

Yes, I will create a 4.4.1 release.

slaff pushed a commit to slaff/Sming that referenced this pull request Oct 19, 2021
* Build is broken, update everything

Immediate problem appears to be `funcparserlib`.
See vlasovskikh/funcparserlib#70.

Found mr2r (mr2 is out of date) and can now use sphinx 4.

* Update theme - bullets missing
slaff pushed a commit to slaff/Sming that referenced this pull request Oct 19, 2021
* Build is broken, update everything

Immediate problem appears to be `funcparserlib`.
See vlasovskikh/funcparserlib#70.

Found mr2r (mr2 is out of date) and can now use sphinx 4.

* Update theme - bullets missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants