Fix some codacy advisories #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikee47 Do you plan to add some more here or I should merge it as it is? |
|
@slaff No, done for now. If you're happy with the changes to the shell scripts, not my area of expertise! |
slaff
reviewed
Oct 14, 2021
Tools/ci/deploy.sh
Outdated
| @@ -41,7 +41,7 @@ PACKAGES_TO_CHANGE="sming sming.source" | |||
|
|
|||
| for PACKAGE in $PACKAGES_TO_CHANGE; | |||
| do | |||
| xmlstarlet ed --inplace -N "ns=http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd" -u "/ns:package/ns:metadata/ns:version" -v "$TAG" packages/$PACKAGE/*.nuspec; | |||
| xmlstarlet ed --inplace -N "ns=http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd" -u "/ns:package/ns:metadata/ns:version" -v "$TAG" "packages/$PACKAGE/*.nuspec"; | |||
There was a problem hiding this comment.
This line will not work as expected. You can replace the last parameter:
"packages/$PACKAGE/*.nuspec"
with
"packages/$PACKAGE/$PACKAGE.nuspec"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been looking through the logs trying to fixup some of these warnings.
Not sure about messing with some of those script files though - difficult to test!
Sure there's more to add here.