Add Ethernet support for ESP32 #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't bother passing MAC to event callback, it's easy to query Disable PHY reset pin by default Implement `EmbeddedEthernet::end()` Add IP methods
Changing SDK config should cause rebuild
Only look in root output directory for component library. Be explicit with other library paths (e.g. mbedtls)
mikee47
force-pushed
the
feature/ethernet
branch
from
f93aff6 to
b7f25c9
Compare
|
Tested on hardware, ready for review. |
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
This PR aims to provide generic Ethernet support for Sming. Initially this is for the ESP32 using its embedded MAC. Note that Sming ESP32 requires a patched version of ESP IDF version 4.3. See #2358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide generic Ethernet support for Sming.
Initially this is for the ESP32 using its embedded MAC.
Note that Sming ESP32 requires a patched version of ESP IDF version 4.3. See #2358.
TODO:
* [ ] Implement SPI-based ethernet devices as supported by ESP32Requires proper SPI support. Leave until HardwareSPI has been updated (NB. Separate future PR to include W5500 support for all devices.)