-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32/network fixes #2325
ESP32/network fixes #2325
Conversation
Don't think that we can start web server AFTER got IP, we need this also for station to configure wifi. |
Thanks for pointing this out. Wrong soluation! The problem in this (and other samples) is the call to |
Actually other sames start webservers after GotIP() so the problem is more widespread. I've done a brief test on the Esp8266, and the IP is allocated after leaving
|
I guess calling these when interface isn't initialised is a genuine logic error.. but could be annoying
Uses a little less RAM.
Bugchecks during HostTests
Do it from `onReady()` handler. All other seem OK.
@mikee47 Ready with this PR? Did you test the changes on a real Esp32? |
Just re-tested with Basic_IFS sample (which is where all this started) and all good. Moved the |
This is on ESP32. All done! |
Don't start webserver until onReady Don't use ESP_ERROR_CHECK so much... Fix Ssl::Options::toString() Change Timer to SimpleTimer for HttpClient. Uses a little less RAM. Increase ESP32 timer task stack size Bugchecks during HostTests.
ESP_ERROR_CHECK
.gotIPonReadyDon't use ESP_ERROR_CHECK so much...
I guess calling these when interface isn't initialised is a genuine logic error.. but could be annoying
Fix
Ssl::Options::toString()
Change
Timer
toSimpleTimer
for HttpClientUses a little less RAM.
Increase ESP32 timer task stack size
Bugchecks during HostTests