Fix bug in StreamTransformer - ending fragment not getting sent #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikee47 Please, add tests to this PR. |
Before:
```
> ChunkedStream / StreamTransformer
758 OK: output.moveString(s)
OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat
61 0d 0a a..
792 FAIL: FS_OUTPUT == s
FAIL in `virtual void StreamTest::execute()`
```
After:
```
>> ChunkedStream / StreamTransformer
741 OK: output.moveString(s)
OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat
61 0d 0a 30 0d 0a 0d 0a a..0....
760 OK: FS_OUTPUT == s
```
|
Before: After: |
slaff
added
3.5 - Approved - Waiting for CI results
and removed
3 - Review
3.5 - Approved - Waiting for CI results
labels
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Apr 27, 2021
…gHub#2317) * Fix bug in StreamTransformer - ending fragment not getting sent * Add test to verify fix Before: ``` > ChunkedStream / StreamTransformer 758 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a a.. 792 FAIL: FS_OUTPUT == s FAIL in `virtual void StreamTest::execute()` ``` After: ``` >> ChunkedStream / StreamTransformer 741 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a 30 0d 0a 0d 0a a..0.... 760 OK: FS_OUTPUT == s ```
slaff
added a commit
that referenced
this pull request
May 4, 2021
…getting sent (#2317) (#2320) * Fix bug in StreamTransformer - ending fragment not getting sent (#2317) * Fix bug in StreamTransformer - ending fragment not getting sent * Add test to verify fix Before: ``` > ChunkedStream / StreamTransformer 758 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a a.. 792 FAIL: FS_OUTPUT == s FAIL in `virtual void StreamTest::execute()` ``` After: ``` >> ChunkedStream / StreamTransformer 741 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a 30 0d 0a 0d 0a a..0.... 760 OK: FS_OUTPUT == s ``` * Fix use-unitialized issue reported by the GCC Host compiler. * Revert "Fix use-unitialized issue reported by the GCC Host compiler." This reverts commit 84fc04c. * Try to supress false-positive error message from GCC 9.2.0 from MinGW. * Trying to fix also Travis builds. Co-authored-by: Mike <[email protected]> Co-authored-by: Slavey Karadzhov <[email protected]>
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Fix bug in StreamTransformer - ending fragment not getting sent
* Add test to verify fix
Before:
```
> ChunkedStream / StreamTransformer
758 OK: output.moveString(s)
OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat
61 0d 0a a..
792 FAIL: FS_OUTPUT == s
FAIL in `virtual void StreamTest::execute()`
```
After:
```
>> ChunkedStream / StreamTransformer
741 OK: output.moveString(s)
OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat
61 0d 0a 30 0d 0a 0d 0a a..0....
760 OK: FS_OUTPUT == s
```
slaff
added a commit
that referenced
this pull request
Dec 24, 2021
* Fix base64 encode length calculation to account for padding (#2307) * Fix base64 encode length calculation Must take padding into account * Make `base64_min_encode_len` and `base64_min_decode_len` functions available publicly. * Add tests to verify that expected output buffer sizes are not exceeded * [Backport to LTS] Fix bug in StreamTransformer - ending fragment not getting sent (#2317) (#2320) * Fix bug in StreamTransformer - ending fragment not getting sent (#2317) * Fix bug in StreamTransformer - ending fragment not getting sent * Add test to verify fix Before: ``` > ChunkedStream / StreamTransformer 758 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a a.. 792 FAIL: FS_OUTPUT == s FAIL in `virtual void StreamTest::execute()` ``` After: ``` >> ChunkedStream / StreamTransformer 741 OK: output.moveString(s) OUTPUT: 65 0d 0a 53 6f 6d 65 20 74 65 73 74 20 64 61 74 e..Some test dat 61 0d 0a 30 0d 0a 0d 0a a..0.... 760 OK: FS_OUTPUT == s ``` * Fix use-unitialized issue reported by the GCC Host compiler. * Revert "Fix use-unitialized issue reported by the GCC Host compiler." This reverts commit 84fc04c. * Try to suppress false-positive error message from GCC 9.2.0 from MinGW. * Trying to fix also Travis builds. Co-authored-by: Mike <[email protected]> Co-authored-by: Slavey Karadzhov <[email protected]> * Store the actual size of the downloaded rBoot item. (#2327) * Fix for SPI debug. (#2382) * Bugfix: WDT::alive() calls wrong function (#2383) * Bugfix: String::replace not using memmove (#2384) Can fail when regions overlap * Bugfix: Edge case in String::replace (#2401) * Fixed a bug with request headers not being reset. (#2424) (#2426) Co-authored-by: Mike <[email protected]> Co-authored-by: Slavey Karadzhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.