Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation fixes for ESP8266 EQT toolchain. #2287

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Compilation fixes for ESP8266 EQT toolchain. #2287

merged 1 commit into from
Mar 24, 2021

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Mar 24, 2021 •
edited
Loading

Solves the following compilation errors:

  1. 'unique_ptr' in namespace 'std' does not name a template type
error: 'unique_ptr' in namespace 'std' does not name a template type
   57 |  std::unique_ptr<uint8_t[]> buffer;
      |       ^~~~~~~~~~
/opt/Sming/Sming/Libraries/OtaUpgrade/OtaUpgrade/EncryptedStream.h:15:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
   14 | #include <sodium/crypto_secretstream_xchacha20poly1305.h>
  +++ |+#include <memory>
   15 |

@slaff slaff added this to the 4.3.0 milestone Mar 24, 2021
mikee47
mikee47 reviewed Mar 24, 2021
View reviewed changes
Sming/Libraries/OtaUpgrade/OtaUpgrade/BasicStream.cpp Outdated
bool ok = rboot_write_flash(&rbootWriteStatus, data, std::min(remainingBytes, size));
bool ok = rboot_write_flash(&rbootWriteStatus, const_cast<uint8_t*>(data), std::min(remainingBytes, size));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required since #2171

@slaff slaff force-pushed the fix/ota-streams-compilation-eqt branch from c7e417b to 3ff3ffd Compare March 24, 2021 14:09
@slaff slaff removed the 3 - Review label Mar 24, 2021
@slaff slaff merged commit a6f41b2 into SmingHub:develop Mar 24, 2021
slaff added a commit that referenced this pull request Mar 24, 2021
@slaff @slav-at-attachix
Compilation fixes for ESP8266 EQT toolchain. (#2287)
396f20a
@slaff slaff mentioned this pull request Mar 30, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 mikee47 left review comments

Assignees
No one assigned
Labels
Port-to-LTS
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @mikee47 @slav-at-attachix