Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vscode configuration support #2231

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Add vscode configuration support #2231

merged 4 commits into from
Feb 26, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Feb 25, 2021 •
edited
Loading

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2021

This pull request introduces 1 alert when merging 1b2a98f into 3d3ddab - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@mikee47 mikee47 force-pushed the feature/vscode-config branch from 1b2a98f to d8a1f13 Compare February 25, 2021 20:18
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2021

This pull request introduces 1 alert when merging d8a1f13 into 3d3ddab - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@mikee47 mikee47 force-pushed the feature/vscode-config branch from d8a1f13 to 3b81792 Compare February 25, 2021 22:35
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2021

This pull request introduces 1 alert when merging 3b81792 into 3d3ddab - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@mikee47
Copy link
Contributor Author

mikee47 commented Feb 26, 2021

This pull request introduces 1 alert when merging 3b81792 into 3d3ddab - view on LGTM.com

new alerts:

* 1 for Wrong name for an argument in a call

This relates to the exist_ok parameter in os.makedirs() call. This parameter was added in python3.x so looks like LGTM is using signatures from python2; perhaps this should be changed?

slaff
slaff reviewed Feb 26, 2021
View reviewed changes
Sming/project.mk Outdated
@@ -430,6 +430,23 @@ $(foreach c,$(BUILDABLE_COMPONENTS),$(eval $(call GenerateComponentTargets,$c)))
# The arch-specific targets, including link and firmware image creation
include $(ARCH_BASE)/app.mk

.PHONY: vscode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could have support for more Integrated Development Environments (IDE)s. How about:

  1. Adding to make help a new topic called "IDE tools"
  2. Rename the vscode* targets to ide-vscode. This way the autocompletion in bash can hint the user to find easily all supported ide operations by typing make ide[PRESS-TAB]

@mikee47
Copy link
Contributor Author

mikee47 commented Feb 26, 2021

@slaff Are you able to try out this on a proper linux box? Specifically, the integrated debugging.

@slaff
Copy link
Contributor

slaff commented Feb 26, 2021

Are you able to try out this on a proper linux box? Specifically, the integrated debugging.

I can try the Host debugging and will let you know.

@mikee47
Copy link
Contributor Author

mikee47 commented Feb 26, 2021

@slaff Thanks. esp8266 debugging has been discussed in past issues but no idea whether the same setup actually works on Linux or not. As noted in documentation, there are also issues with the debug output not being 'clean' but these things can be addressed as required I guess.

@mikee47 mikee47 force-pushed the feature/vscode-config branch 2 times, most recently from 10425e4 to 07959f7 Compare February 26, 2021 09:14
@mikee47
Implement slaff's idea to support for more Integrated Development Env…
141ff45 
…ironments (IDE)s

Add new help topic called "IDE tools"
Rename vscode target to ide-vscode. This way the autocompletion in bash can hint the user to find easily all supported ide operations by typing make ide[PRESS-TAB]
@mikee47 mikee47 force-pushed the feature/vscode-config branch from 07959f7 to 141ff45 Compare February 26, 2021 09:36
@slaff
Copy link
Contributor

slaff commented Feb 26, 2021

Host debugging works very well.

image

@slaff
Copy link
Contributor

slaff commented Feb 26, 2021 •
edited
Loading

Unfortunately I did not have success with the Esp8266 debugger. Getting back: Remote replied unexpectedly to 'vMustReplyEmpty'. Might be related to the newer version of gcc and SDK. This could be the answer: pulp-platform/debug_bridge#1 (comment) and the fix: stefanct/debug_bridge@5cad415

@slaff slaff added this to the 4.3.0 milestone Feb 26, 2021
@mikee47
Copy link
Contributor Author

mikee47 commented Feb 26, 2021

I use this with WSL and works with current tools

https://github.com/SmingHub/Sming/blob/61dc191d16e5148b016fd3672350ecbb680b4061/Tools/WSL/tcp_serial_redirect.py

@slaff slaff merged commit ef18984 into SmingHub:develop Feb 26, 2021
@slaff slaff mentioned this pull request Feb 26, 2021
Closed
5 tasks
@mikee47 mikee47 deleted the feature/vscode-config branch February 26, 2021 13:37
@mikee47 mikee47 mentioned this pull request Feb 26, 2021
Merged
7 tasks
mikee47 added a commit to mikee47/Sming that referenced this pull request Feb 27, 2021
@mikee47 @slav-at-attachix
Add vscode configuration support (SmingHub#2231)
646e6c3 
* Add `vscode` build target

* Update docs

Add new help topic called "IDE tools"
Rename vscode target to ide-vscode. This way the autocompletion in bash can hint the user to find easily all supported ide operations by typing make ide[PRESS-TAB]

Co-authored-by: Slavey Karadzhov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaff slaff slaff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mikee47 @slaff @slav-at-attachix