Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removed spiffs-image-clean #2225

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Revert removed spiffs-image-clean #2225

merged 1 commit into from
Feb 23, 2021

Conversation

Matzz
Copy link
Contributor

@Matzz Matzz commented Feb 22, 2021

It was removed in #2171 but is required by spiffs-image-update

@slaff slaff requested a review from mikee47 February 23, 2021 07:59
@slaff slaff added this to the 4.3.0 milestone Feb 23, 2021
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should have remained! Thanks.

@mikee47
Copy link
Contributor

mikee47 commented Feb 23, 2021

Note also that we could probably do with targets to clean/re-build other partitions, e.g. make part-image-update, part-image-clean.

@slaff slaff removed the 3 - Review label Feb 23, 2021
@slaff slaff merged commit 9e55859 into SmingHub:develop Feb 23, 2021
@slaff
Copy link
Contributor

slaff commented Feb 23, 2021

Note also that we could probably do with targets to clean/re-build other partitions, e.g. make part-image-update, part-image-clean.

Sounds like a new PR to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants