Initial DIAL (http://www.dial-multiscreen.org/) client. #2136

slaff · 2020-11-03T17:32:15Z

Allows Sming applications to control remote monitors/TVs.
@piperpilot For example a Sming application can open YouTube on a smart TV and display a video when the BBQ is ready.

mikee47

I've made a few suggestions via commits (take 'em or leave 'em). On namespaces should we use DIAL for consistency?

slaff · 2020-11-06T04:34:55Z

I've made a few suggestions via commits (take 'em or leave 'em).

Thanks. All looks good to me.

On namespaces should we use DIAL for consistency?

Better not. Better have the same coding style for namespaces as for classes. Which reminds me that mDns should be renamed to Mdns and it is probably a good idea to do it before the 4.2 release.

mikee47 · 2020-11-06T07:24:38Z

On namespaces should we use DIAL for consistency?

Better not. Better have the same coding style for namespaces as for classes. Which reminds me that mDns should be renamed to Mdns and it is probably a good idea to do it before the 4.2 release.

I think the main reason for upper-camelcase names is consistency to avoid silly typos, although that should be negated using eclipse, etc. It feels more important that the name is correct, which for network protocols means TCP, mDNS, UPnP, SSDP, etc. There's a good reason you picked mDNS in the first place!

May I suggest we simply add namespace aliases, i.e. namespace Mdns = mDns and could even add MDNS and mdns? I can do the same with SSDP/UPnP. That would allow application developers to use whichever convention feels natural to them, but libraries would always use the correct one internally.

mikee47 · 2020-11-06T08:37:26Z

@slaff I'm doing some revisions to UPnP library which should help to streamline this PR. Should have them out today.

slaff · 2020-11-06T10:29:06Z

Sming/Libraries/DIAL/sample/app/application.cpp

@@ -7,7 +7,9 @@
 #define WIFI_PWD "PleaseEnterPass"
 #endif

-static Dial::Client client;
+namespace


@mikee47 I will remove the anonymous namespace. If we apply this change it should be applied to all samples for consistency. Which can be part of a separate PR.

mikee47 · 2020-11-06T12:53:33Z

@slaff The Dial::Client is very interesting as it demonstrates behaviour that UPnP::ControlPoint should handle. Specifically, tracking unique service names and fetching descriptions. I could pull that out now, or leave it for another PR?

slaff · 2020-11-06T15:33:36Z

I could pull that out now,

@mikee47 Do you mean to create a separate repository for the Dial client? If yes, I will make this. I wanted to change also the naming of one flash variable... let me do it first...

slaff · 2020-11-06T15:36:49Z

Specifically, tracking unique service names and fetching descriptions. I could pull that out now, or leave it for another PR?

Or you have meant to put the tracking and fetching of the description from Dial::Client into UPnP::ControlPoint ? If yes - let's finish with this PR and you can make your changes in a separate PR for it. Is that ok for you?

mikee47 · 2020-11-06T15:54:24Z

@slaff I've kind of done it already :-) I'll push the changes and see what you think - also found an important bug in TCP.

Common code, add `sendRunRequest()` applicationUrl is stored but never changed so just noting the appsUrl seems appropriate, then calculate when required. If I understand the logic correctly, instanceUrl should **only** be set by incoming response. It should therefore not be initialised at all.

This reverts commit 134175d.

…don't store until request queued

mikee47 · 2020-11-06T18:06:57Z

@slaff Thank you for your work in getting this control point stuff started, looking really good! I've opened an issue to discuss and track changes necessary before Sming 4.2 release.

slaff · 2020-11-06T18:20:04Z

@mikee47 Shall I wait for you or better merge it as it is in develop and the move it into a separate repository?

mikee47 · 2020-11-06T18:23:02Z

@slaff I think go ahead and move it, feels like a good place to shove a stick in the mud.

slaff added the 3 - Review label Nov 3, 2020

slaff added this to the 4.2.0 milestone Nov 3, 2020

slaff mentioned this pull request Nov 3, 2020

[WIP] Panasonic Viera TV remote control #2137

Closed

slaff changed the title ~~Initial DIAL (http://www.dial-multiscreen.org/) client.~~ [WIP] Initial DIAL (http://www.dial-multiscreen.org/) client. Nov 4, 2020

slaff mentioned this pull request Nov 5, 2020

Updated RapidXML to latest version. #2141

Closed

slaff changed the title ~~[WIP] Initial DIAL (http://www.dial-multiscreen.org/) client.~~ Initial DIAL (http://www.dial-multiscreen.org/) client. Nov 5, 2020

slaff force-pushed the feature/multimedia-dial-client branch from 00a6c21 to a1e8446 Compare November 5, 2020 09:33

slaff requested a review from mikee47 November 5, 2020 09:36

mikee47 force-pushed the feature/multimedia-dial-client branch from 84c1141 to cbb5515 Compare November 5, 2020 23:21

mikee47 reviewed Nov 5, 2020

View reviewed changes

slaff commented Nov 6, 2020

View reviewed changes

slav-at-attachix and others added 12 commits November 6, 2020 17:43

Initial DIAL (http://www.dial-multiscreen.org/) client.

89fe83c

Improved DIAL documentation.

9f323c5

Simplified the DIAL client to use the XML::getNode function.

c0e0b3e

Libraries shouldn't use SmingCore.h

f105430

Define service_urn as default

2aaac05

Use IDataSourceStream::moveString to avoid up-cast and simplify code

cb9d211

Deprecated method

a7e464a

enum MimeType is a C-thing

5ea8990

More efficient use of map

4eb56d5

Could just call the delegate Connected ?

ea2ee04

Use response.isSuccess()

77d94bc

mikee47 and others added 16 commits November 6, 2020 17:44

Return object reference& instead of pointer (never null)

b6f54fc

Use anonymous namespaces

1646e17

Use F() instead of _F() as method requires String& anyway

5b9964f

Try not to use printf or c_str() if possible

9972b5a

Update libraries

b01a046

Revert "Use anonymous namespaces"

7156fd3

This reverts commit 134175d.

Remove bad code

2656b28

Create samples directory and move DIAL_Client into it

b1339b4

MultipartStream.h not used by HttpRequest - move header

aad210c

Move request handling into ControlPoint class

8ebfa9e

DeviceHost should be initailised by application

9b75d16

Change connect methods and callback

0e930a9

Add check on null TCP blocks

d322b3a

If request queue is full then won't ever get service description, so …

f091657

…don't store until request queued

Move search logic into ControlPoint, access via beginSearch method.

9f9d654

Fixes for rebase

a96d038

mikee47 force-pushed the feature/multimedia-dial-client branch from 27e6592 to a96d038 Compare November 6, 2020 18:04

slaff removed the 3 - Review label Nov 7, 2020

slaff merged commit a76c061 into SmingHub:develop Nov 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial DIAL (http://www.dial-multiscreen.org/) client. #2136

Initial DIAL (http://www.dial-multiscreen.org/) client. #2136

slaff commented Nov 3, 2020

mikee47 left a comment

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020 •

edited

Loading

mikee47 commented Nov 6, 2020

slaff Nov 6, 2020

mikee47 commented Nov 6, 2020

slaff commented Nov 6, 2020

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020

mikee47 commented Nov 6, 2020

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020

Initial DIAL (http://www.dial-multiscreen.org/) client. #2136

Initial DIAL (http://www.dial-multiscreen.org/) client. #2136

Conversation

slaff commented Nov 3, 2020

mikee47 left a comment

Choose a reason for hiding this comment

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020 • edited Loading

mikee47 commented Nov 6, 2020

slaff Nov 6, 2020

Choose a reason for hiding this comment

mikee47 commented Nov 6, 2020

slaff commented Nov 6, 2020

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020

mikee47 commented Nov 6, 2020

slaff commented Nov 6, 2020

mikee47 commented Nov 6, 2020

mikee47 commented Nov 6, 2020 •

edited

Loading