Stream optimisations #2123
Merged
Stream optimisations #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HostTests has added speed tests using Json6. Here's a summary of the changes running on a NodeMCU. Times are in microseconds:
|
This comment has been minimized.
This comment has been minimized.
mikee47
force-pushed
the
feature/stream-optimisations
branch
2 times, most recently
from
3f455c1 to
24da373
Compare
Remove `nextStream` and make `stream` private. Remove `onNextStream` method and implement logic within MultipartStream::getNextStream. Deprecate `HttpPartResult`, rename as `MultipartStream::BodyPart`. Depreate `HttpPartProducerDelegate`, rename as `MultipartStream::Producer`.
# Conflicts: # Sming/Wiring/Stream.h
Also add a couple of extra null ptr checks
Attempting to write data larger than available space discards all of it. Correct behaviour is to write as much as possible, but still discard the remainder. Also, seek operation (for reading) is now bi-directional between the start of the buffer and the current write position.
mikee47
force-pushed
the
feature/stream-optimisations
branch
from
24da373 to
2e89b92
Compare
…nse::getBody()` methods. Use move semantics.
mikee47
force-pushed
the
feature/stream-optimisations
branch
from
2e89b92 to
7d1f68d
Compare
|
@mikee47 Is this PR ready for merging? |
|
@slaff Yes, all done |
slaff
pushed a commit
to mikee47/Sming
that referenced
this pull request
Dec 2, 2020
…in wrong multipart boudary headers and endless loop. This commit removes the introduced problems.
slaff
pushed a commit
to mikee47/Sming
that referenced
this pull request
Dec 2, 2020
…in wrong multipart boudary headers and endless loop. This commit removes the introduced problems.
slaff
pushed a commit
to mikee47/Sming
that referenced
this pull request
Dec 3, 2020
…in wrong multipart boudary headers and endless loop. This commit removes the introduced problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Multipart streams
nextStreamand makestreamprivate.onNextStreammethod and implement logic within MultipartStream::getNextStream.HttpPartResult, rename asMultipartStream::BodyPart.HttpPartProducerDelegate, rename asMultipartStream::Producer.Wiring Stream
Stream.hand regularise commentsconst char*Fix LimitedMemoryStream, and add
getStreamPointermethodAdd serialization speed checks in HostTests