Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to Http response/request and Udp #2117

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Small updates to Http response/request and Udp #2117

merged 5 commits into from
Oct 19, 2020

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Oct 19, 2020

  • added methods to control multicast Time-To-Live(TTL) and multicast IP
  • made the toString() methods in HttpRequest and HttpResponse to be available also in SMING_RELEASE mode.

@slaff slaff added this to the 4.2.0 milestone Oct 19, 2020
@slaff slaff requested a review from mikee47 October 19, 2020 09:12
mikee47
mikee47 requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used some igmp_joingroup amd igmp_leavegroup functions in SSDP Server.cpp, could you perhaps add those as well?

Sming/Core/Network/Http/HttpRequest.cpp Outdated Show resolved Hide resolved
Sming/Core/Network/Http/HttpRequest.cpp Outdated Show resolved Hide resolved
Sming/Core/Network/Http/HttpRequest.h Outdated Show resolved Hide resolved
Sming/Core/Network/Http/HttpResponse.cpp Outdated Show resolved Hide resolved
Sming/Core/Network/Http/HttpResponse.cpp Outdated Show resolved Hide resolved
@slaff slaff force-pushed the udp-multicast-http-both-to-string branch from 01c7ca8 to f448ed5 Compare October 19, 2020 10:07
slav-at-attachix and others added 2 commits October 19, 2020 12:21
@slav-at-attachix
Added join/leave to/from multicast groups in IpConnection class.
1124675
@mikee47
Tested with SSDP server, changes made.
6fcb4f6 
Scope of igmp.h can be reduced to within IpConnection unit.
Member scope must be public
Clarify method descriptions (using igmp.c as guide) and add overload to simplify usage
Fix comments and headers
@slaff
Copy link
Contributor Author

slaff commented Oct 19, 2020

@mikee47 Thanks for the fixes. Shall I merge also this PR or you have some more changes in the back of your mind?

@slaff slaff merged commit fa5682f into SmingHub:develop Oct 19, 2020
@slaff slaff removed the 3 - Review label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 mikee47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @mikee47 @slav-at-attachix