CS5460 Arduino library #2106
Merged
CS5460 Arduino library #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
reviewed
Sep 13, 2020
| #ifndef __CS5460_H__ | ||
| #define __CS5460_H__ | ||
|
|
||
| -#include <arduino.h> |
There was a problem hiding this comment.
Can you try to replace <arduino.h> with <Arduino.h> and see if the library compiles and works?
There was a problem hiding this comment.
Thanks for updating it!
|
@kmihaylov Just noticed there's no README for this library, would you add one please? This is all we get on the doc. page: See https://sming.readthedocs.io/en/latest/contribute/documentation.html#readme-files for further details. |
|
Sure. I'll need few days to react. Also the setting of the filters in the example is incorrect.
…On October 12, 2020 12:00:13 AM GMT+03:00, Mike ***@***.***> wrote:
@kmihaylov Just noticed there's no README for this library, would you
add one please? This is all we get on the doc. page:
https://sming.readthedocs.io/en/latest/_inc/Sming/Libraries/CS5460/index.html
See
https://sming.readthedocs.io/en/latest/contribute/documentation.html#readme-files
for further details.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2106 (comment)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CS5460 library from this author: https://github.com/xxzl0130/CS5460
CS5460 IC is widely found in socket power meters. It can calculate RMS values and is used for electrical measurements voltage, current, power factor, energy, etc.
The provided sample is tested, however due to the dangerous voltage (my test board measures 230VAC) I couldn't provide quality video.
Please note that CS5460 requires calibration, use of (internal) filters, reset line use is more than recommended.
The component is build with the default MISO pin set to 12 (default on ESP-12F).