Make String object size configurable #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the largest size. SSO length is stored in 7 bits so can be at most 127 chars.
|
Continuing from #1951 the disadvantage of increasing string size is we can't use the space once the String switches out of SSO mode, so the additional allocation becomes an overhead. One way to solve this is to make SSO_CAPACITY a template parameter so Strings can be defined with different values to suit requirements. That would require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSO length is stored in 7 bits so can be at most 127 chars.
Revise tests to accommodate the largest size.