Add string tests from Arduino ESP8266 core #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
update/arduino-string-tests
branch
from
9dc47b0 to
aa99573
Compare
…tests Add `getTotal()` and `resetTotal()` to malloc count
…isation disabled)
mikee47
force-pushed
the
update/arduino-string-tests
branch
from
aa99573 to
d8bb1cd
Compare
|
@mikee47 do you have something to add here before I merge this PR? |
|
@slaff All done thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to #1951 I'm propsing the addition of these tests. This is a cut & paste job with minor amendments to fit the HostTests framework. As we don't yet have SSO and Sming doesn't have StringStream those tests have been commented out.
Bugfix: non-decimal negative #s should be as if they were unsigned