Add deprecation warning to flashmem_get_address()
#1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slaff Any thoughts on this patch? |
|
Since we don't use this in the framework (at present) but will shortly, I'll revert this patch but add a deprecation warning just in case anyone's used it. |
mikee47
force-pushed
the
fix/flashmem_get_address
branch
from
4c6697f to
b4f975f
Compare
mikee47
changed the title
flashmem_get_address() to account for rBoot mappingflashmem_get_address()
mikee47
force-pushed
the
fix/flashmem_get_address
branch
from
b4f975f to
cbdef55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #1490 but not currently used within the framework.
This function maps a PROGMEM address to the corresponding flash location, but doesn't work if program space has been remapped by rBoot.
I will fix this properly in a separate upgrade to Host flash memory handling and FlashStrings.