Fix some Coverity advisories #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
reviewed
Oct 26, 2019
| @@ -48,6 +48,7 @@ WebsocketConnection::WebsocketConnection(HttpConnection* connection, bool isClie | |||
| { | |||
| setConnection(connection, isClientConnection); | |||
|
|
|||
| memset(&parser, 0, sizeof(parser)); | |||
There was a problem hiding this comment.
It would be better to move memset inside of ws_parser_init.
mikee47
force-pushed
the
fix/coverity-warnings
branch
from
950c7c6 to
cd925a6
Compare
mikee47
force-pushed
the
fix/coverity-warnings
branch
from
cd925a6 to
71d65cd
Compare
mikee47
added a commit
to mikee47/Sming
that referenced
this pull request
Nov 3, 2019
slaff
pushed a commit
that referenced
this pull request
Nov 3, 2019
* Fix strncpy * Fix `getHostAppDir()`, broken in #1913.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.