Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Updated coding style check. #1738

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Jul 2, 2019

No description provided.

@slaff slaff force-pushed the fix/travis-cs-file-list branch from 4fbd54b to 698c1dc Compare July 2, 2019 17:27
@mikee47
Copy link
Contributor

mikee47 commented Jul 2, 2019

@slaff Thanks. Doesn't pick up the HardwarePWM.cpp from previous commit; is there any reason we can't just check every file? i.e. get rid of commit filter?

@slaff
Copy link
Contributor Author

slaff commented Jul 2, 2019

Doesn't pick up the HardwarePWM.cpp

Yes, there are two issues that I have seen, one of them is:

  • if you force-commit then travis does not pass correct sha1 values and the script ends up in flames with
fatal: ambiguous argument '4fbd54bb1f2e...698c1dc1a076': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

i.e. get rid of commit filter?

It would be probably better to get rid of the script and use make cs and check the diff. If there is a diff content then we print it and exit with 1. This way we need to keep the folders that have to be checked only in one place.

@slaff slaff force-pushed the fix/travis-cs-file-list branch from 698c1dc to 3c0e956 Compare July 2, 2019 20:12
@slaff slaff changed the title Updated list of files to format. CI: Updated coding style check. Jul 2, 2019
@mikee47
Copy link
Contributor

mikee47 commented Jul 2, 2019

Nice solution!

@slaff slaff added this to the 3.9.0 milestone Jul 3, 2019
@slaff slaff mentioned this pull request Jul 3, 2019
@slaff slaff removed the 3 - Review label Jul 3, 2019
@slaff slaff merged commit 28ef038 into SmingHub:develop Jul 3, 2019
@slaff slaff deleted the fix/travis-cs-file-list branch July 22, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants