Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fileSetContent() to return a result #1657

Merged
merged 6 commits into from
Apr 2, 2019

Conversation

kmihaylov
Copy link
Contributor

Instead of void, fileSetContent() now returns a result of the operation (fileOpen or fileWrite) and in case of error, the error code (available in third-party/spiffs/src/spiffs.h) will be returned.

@slaff
Copy link
Contributor

slaff commented Apr 1, 2019

@kmihaylov Make sure to run make cs to auto-fix the coding style once you are done with your changes. Take a look at Coding-Style-Rules for details. We use clang-format version 6.

@slaff slaff added this to the 3.8.0 milestone Apr 1, 2019
@slaff slaff removed the 3 - Review label Apr 2, 2019
@slaff slaff merged commit ccc7e68 into SmingHub:develop Apr 2, 2019
@slaff slaff mentioned this pull request Apr 5, 2019
4 tasks
@kmihaylov kmihaylov deleted the fix/spiffs-fileSetContent-result branch April 7, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants