Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpClientConnection class #1624

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Feb 14, 2019

New class simplifies HttpClient and manages request queue and ssl information.
Rename HttpRequest::request() to createRequest(), deprecate old version.

Trivial code moved into headers
NULL -> nullptr
int -> unsigned as appropriate
Remove un-necessary __forceinline directives
Manages request queue and ssl information, so HttpClient only needs to track connections.
Also deal with SSLSessionId class.
@@ -68,13 +72,15 @@ class HttpClient
*/
bool send(HttpRequest* request);

HttpRequest* request(const String& url);
HttpRequest* request(const String& url) __attribute__((deprecated))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, put here in doc comments also @deprecated. This way doxygen will add the method automatically to the deprecated list.

****/

#include "HttpClientConnection.h"
#include "Data/Stream/FileStream.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the FileStream include needed here?

@slaff slaff added this to the 3.7.2 milestone Feb 14, 2019
Add comment to deprecated function
Remove errant #include
@slaff slaff removed the 3 - Review label Feb 15, 2019
@slaff slaff merged commit fe44e59 into SmingHub:develop Feb 15, 2019
@mikee47 mikee47 deleted the fix/HttpClientConnection branch February 15, 2019 17:41
@slaff slaff mentioned this pull request Feb 27, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants