Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mqtt fifo memleak #1612

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Fix/mqtt fifo memleak #1612

merged 2 commits into from
Feb 11, 2019

Conversation

etmmahi
Copy link
Contributor

@etmmahi etmmahi commented Feb 10, 2019

When adding too many messages to the MQTT requestqueue they get dropped when the queue is full. In this case, the allocated memory is not released. This fix first checks if there is room in the queue.

May also fix #1576

@slaff slaff added this to the 3.7.2 milestone Feb 10, 2019
@slaff slaff merged commit 81f5d10 into SmingHub:develop Feb 11, 2019
@slaff
Copy link
Contributor

slaff commented Feb 11, 2019

@etmmahi Thanks for the fix!

@etmmahi etmmahi deleted the fix/mqtt_fifo_memleak branch February 11, 2019 13:49
@slaff slaff mentioned this pull request Feb 27, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent mqtt publish eats heap
2 participants