Refactoring websocket client and server. #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaff
force-pushed
the
refactoring/websocket-client-latest
branch
from
bde7db7 to
8744c8b
Compare
Renamed the method making the `binding` to a http server socket to be called `bind`. Fix for potential memory leak + Codacy fixes. Reapplied coding-standards. Small changes. Updated the example to update every 20 seconds instead of 60. Better init and deinit of streams Added timeouts to keep the connection for longer periods. Reset the HttpConnection timeout on a new connect. - Don't send new HTTP request over the same TCP connection if is already started. - Make HttpConnection::reset to be extendable. This allows also the WebsocketClient to reset the connection. Use SSL by default Refactored the HttpClient and Connection to reuse code. Refactored the WebsocketConnection to be reused in server and client mode.
slaff
force-pushed
the
refactoring/websocket-client-latest
branch
from
8744c8b to
fdfca22
Compare
slaff
changed the title
slaff
force-pushed
the
refactoring/websocket-client-latest
branch
from
2f0c52a to
cce7822
Compare
slaff
force-pushed
the
refactoring/websocket-client-latest
branch
from
51f886c to
701e161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Simplified and decreased the code base responsible for the Websocket functionality.
Refactored the WebsocketConnection to be reused in server and client mode.
Documentation for the updated connections.
Breaking Changes (Impact: High)
If you use Websocket functionality make sure to read the notes below.
Renamed Websocket related types, classes and methods. We used to have
WebSocketandWebsocket. From now on onlyWebsocketwill be used. ExampleWebsocketConnection::getActiveWebSocketsis nowWebsocketConnection::getActiveWebsockets.WebsocketConnection
Renamed the method making the
bindingto a http server socket to be calledbind.WebsocketClient
All methods starting with
setWebSocketare shortened toset. Example:setWebSocketMessageHandleris renamed tosetMessageHandler.Fixes: #1416.