Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to FileStream class #1510

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Changes to FileStream class #1510

merged 1 commit into from
Oct 25, 2018

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 24, 2018

  • Add close() method
  • Change size, pos to size_t
  • Handle value < 0 if invalid
  • bugfix: available() returned wrong value
  • Remove write(uint8_t) method, implemented in ReadWriteStream
  • Add getLastError() method and track file error code internally
  • Additional file API error checks
  • Don't prevent negative offsets in seek() method, perfectly legitimate
  • Track file position in write() method

@mikee47
Changes to FileStream class
3eced66 
* Add close() method
* Change size, pos to size_t
* Handle value < 0 if invalid
* bugfix: available() returned wrong value
* Remove write(uint8_t) method, implemented in ReadWriteStream
* Add getLastError() method and track file error code internally
* Additional file API error checks
* Don't prevent negative offsets in seek() method, perfectly legitimate
* Track file position in write() method
@slaff slaff added this to the 3.7.0 milestone Oct 25, 2018
@slaff slaff merged commit 48f3a55 into SmingHub:develop Oct 25, 2018
@mikee47 mikee47 deleted the feature/FileStream_improvements branch October 25, 2018 17:45
@slaff slaff mentioned this pull request Oct 29, 2018
Closed
4 tasks
@slaff slaff removed the 3 - Review label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff