Revise SplitString #1508
Merged
Revise SplitString #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikee47
commented
Oct 24, 2018
mikee47
commented
- Doesn't need to be a friend of String, but #included inside WString.h for convenience
- Use unsigned instead of int where appropriate
- Minor improvements
* Doesn't need to be a friend of String, but #included inside WString.h for convenience * Use unsigned instead of int where appropriate * Minor improvements
slaff
requested changes
Oct 24, 2018
Sming/Wiring/SplitString.cpp
Outdated
| } | ||
|
|
||
| int pieceCount = splitCount + 1; | ||
| /* $Id: WMemory.cpp 1156 2011-06-07 04:01:16Z bhagman $ |
There was a problem hiding this comment.
WMemory.cpp -> SplitString.cpp.
slaff
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.