Various improvements to NtpClient class #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix #include guard name * Tidy #includes * Put NTP_DEFAULT_SERVER into Flash * Use const String& for parameters * Use SimpleTimer instead of Timer as appropriate (efficiency, saves RAM) * timeoutTimer doesn't need to be initialised until a request has been queued, so moved out of constructor * Replace staticDnsResponse() with lambda * Tidy extraction of timestamp from received packet using LWIP macro
* Rewrite using one timer * Set timer to retry on initial request, and only stop it on success or cancellation * Add retry if bad NTP packet received * Change int arguments to unsigned
|
I've emulated the synchronization problem of #1449 by giving Patch for the above test using |
slaff
reviewed
Oct 17, 2018
| // init timer but do not start, correct interval set later below. | ||
| autoUpdateTimer.initializeMs(NTP_DEFAULT_QUERY_INTERVAL_SECONDS * 1000, | ||
| TimerDelegate(&NtpClient::requestTime, this)); | ||
| debug_d("NtpClient(\"%s\", %u, 0x%08x", reqServer.c_str(), reqIntervalSeconds, delegateFunction); |
There was a problem hiding this comment.
@mikee47 We have a problem here. Either remove the delegateFunction parameter or replace it something like delegateFunction ? 1:0. Or cast it to an address, if that was the initial intention.
In order to reproduce the problem compile Sming with DEBUG_VERBOSE_LEVEL=3.
cd %SMING_HOME%
make dist-clean
make DEBUG_VERBOSE_LEVEL=3
There was a problem hiding this comment.
That was silly of me! I've removed the parameter, doesn't really help anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with SystemClock_NTP sample, but note that time will be wrong as we don't yet have any timezone management in place. The sample also sets local time, but NTP provides time in UTC. No point in fixing that yet as without timezone it just makes things worse.
Closes: #1449