Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the streams #1377

Merged
merged 4 commits into from
May 15, 2018
Merged

Refactored the streams #1377

merged 4 commits into from
May 15, 2018

Conversation

slaff
Copy link
Contributor

@slaff slaff commented May 14, 2018

  • to prepare for the coming SmtpClient
  • to organize the stream classes in their own folder

Migration from v. 3.5.2 or ealrier

Those changes will affect your code only if you use directly in your application the following classes.

  • HttpMultipartStream

    • HttpMultipartStream is renamed to MultipartStream
    • SmingCore/Network/Http/Stream/HttpMultipartStream.h is moved to SmingCore/Data/Stream/MultipartStream.h
  • HttpChunkedStream.h

    • HttpChunkedStream is renamed to ChunkedStream
    • SmingCore/Network/Http/Stream/HttpChunkedStream is moved to SmingCore/Data/Stream/ChunkedStream.h
  • DataSourceStream.h and OutputStream.h are now located in SmingCore/Data/Stream/.

  • CircularBuffer.h is moved to SmingCore/Data/.

  • URL - if you use protocol different than HTTP then the default port will be set to 0. In the previous versions the default port was always 80, no matter what the URL protocol was.

- Moved the streams from SmingCore/Network/Http/Stream to SmingCore/Data/Stream. They will be used also in the coming SmtpClient.
- Unified the stream transformation code and added it to Streamtransfomer.
- Removed deprecated method name from CircularBuffer.
- Moved common data structures from HttpCommon.h to SmingCore/Data/Structures.h
Added NetUtils compat with Linux.
@slaff slaff added this to the 3.6.0 milestone May 14, 2018
@slaff slaff force-pushed the refactoring/streams branch from 265bc72 to 18c11ad Compare May 14, 2018 13:26
@slaff slaff mentioned this pull request May 14, 2018
@slaff slaff merged commit e7f927f into SmingHub:develop May 15, 2018
@slaff slaff mentioned this pull request May 15, 2018
24 tasks
@slaff slaff removed the 3 - Review label May 18, 2018
@slaff slaff deleted the refactoring/streams branch July 22, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants