HardwareSerial: Fix for zero availableCharsCount in callback if there… #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are more than 15 chars available.
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Mar 5, 2018
…ree heap memory at your disposable and less bugs. - [x] Unified the stream classes for better testability and reusability. (SmingHub#1332) The `length()` method in the DataSourceStream classes is deprecated and will be removed in the coming versions. Use `available()` instead. - [x] MacOS compatibility issues. (SmingHub#1316) - [x] Memory Optimization: Moved C++ vtables into IRAM, out of HEAP. In some cases increased the free heap with 3K. (SmingHub#1320) - [x] Updated axTLS to its latest version and increased available free heap (SmingHub#1329). - [x] Decreased the default debug messages in the network layer (SmingHub#1327) as part of our effort to provide better out-of-the-box experience (SmingHub#1328) - [x] Reorganization: Moved the tools under tools/ folder and added esptool2 as submodule as part of the better experience. - [x] Fix: Added linker flags to allow the use of custom crash handlers in the user code. (SmingHub#1326) - [x] Small fix to the FreeBSD make mechanism. - [x] HardwareSerial: Fix for zero availableCharsCount in callback ... (SmingHub#1307) - [x] Adds Cygwin32 build support (SmingHub#1306) - [x] Modified libemqtt & MqttClient to allow the publishing of binary messages (SmingHub#1300) All PRs scheduled for this release can be seen from [here](https://github.com/SmingHub/Sming/milestone/14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… are more than 15 chars available.
In HardwareSerial::callbackHandler the encoding of last character, number of available characters and the uart nr is done like this:
void HardwareSerial::callbackHandler(uart_t *uart) {
...
uint32 serialQueueParameter;
uint16 cc = uart_rx_available(uart);
serialQueueParameter = (cc * 256) + receivedChar;
serialQueueParameter += (uart->uart_nr << 25);
...
}
The logic & for the decoding in HardwareSerial::delegateTask is done on 0x0FFF. But one F stands for 4 bit. So we need six F.