Add compatibility with Espressif SDK 2.1.0 published in git repository #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compatibility with ESP SDK 2.1.0 by removing extra extern declaration of SDK stuff and by including proper SDK headers where needed
slaff
requested changes
Jun 13, 2017
| @@ -157,7 +157,8 @@ void Adafruit_ILI9341::begin(void) { | |||
| transmitCmdData(0xE1, data, 15); //Set Gamma | |||
|
|
|||
| transmitCmd(0x11); //Exit Sleep | |||
| os_delay_us(120000); | |||
There was a problem hiding this comment.
@avr39-ripe Can you remove that change from the PR. As far as I can see it has nothing to do with SDK 2.1.0.
There was a problem hiding this comment.
it is mandatory change. without this this library do not compile any more. Old os_delay_us declaration was uint32_t and new, from esp sdk 2.1.0 is uint16_t, so I made such "strange" change here.
There was a problem hiding this comment.
More code should be reviewed then to check if delays do not excede 65,535 limit.
|
@avr39-ripe Why not mandatory, it would be very helpful if we can add also SDK 2.1.0 in our CI system. |
|
@slaff do not know nothing about how to add sdk 2.1.0 to CI :( can you help with it? |
|
Will be merged with rebase PR #1264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility with ESP SDK 2.1.0 by removing extra extern declaration of SDK stuff and by including proper SDK headers where needed