Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI: transfer functions ignore byte order #709

Closed
mtavenrath opened this issue Apr 20, 2016 · 1 comment
Closed

SPI: transfer functions ignore byte order #709

mtavenrath opened this issue Apr 20, 2016 · 1 comment

Comments

@mtavenrath
Copy link
Contributor

The functions SPIClass:tranfer32 and SPIClass::transfer both initialize regvalue to 0 instead of keeping SPI_WR_BYTE_ORDER and SPI_RD_BYTE_ORDER. This way the MSB/LSB setting is ignored when transfering data.
Phaeodaria pushed a commit to mtavenrath/Sming that referenced this issue Apr 20, 2016
Fix issue SmingHub#709. Keep SPI_WR_BYTE_ORDER and SPI_RD_BYTE_ORDER …
cc303fd 
…when updating the SPI_USER reg
@harry-boe
Copy link
Contributor

pls check my comments on #710

Phaeodaria pushed a commit to mtavenrath/Sming that referenced this issue Apr 21, 2016
@mtavenrath
Fix issue SmingHub#709. Keep SPI_WR_BYTE_ORDER, SPI_RD_BYTE_ORDER, an…
5fbf118 
…d | bSPI_CK_OUT_EDGE when upddating the SPI_USER reg
Phaeodaria pushed a commit to mtavenrath/Sming that referenced this issue Apr 21, 2016
@mtavenrath
Fix issue SmingHub#709. Keep SPI_WR_BYTE_ORDER, SPI_RD_BYTE_ORDER, an…
04ef33e 
…d SPI_CK_OUT_EDGE when upddating the SPI_USER reg
@hreintke hreintke added the Ideas label Apr 22, 2016
slaff pushed a commit that referenced this issue Dec 6, 2016
@mtavenrath @slaff
Fix issue #709. Keep SPI_WR_BYTE_ORDER, SPI_RD_BYTE_ORDER, and SPI_CK…
c23f203 
…_OUT_EDGE when upddating the SPI_USER reg (#710)
@slaff slaff closed this as completed Dec 6, 2016
@hreintke hreintke removed the Ideas label Dec 6, 2016
johndoe8967 added a commit to johndoe8967/Sming that referenced this issue Dec 10, 2016
@johndoe8967
Merge remote-tracking branch 'upstream/develop' into upstream_develop
138bb3a 
* upstream/develop: (21 commits)
  Added crash handler. Fixed/improved debugging information. (SmingHub#826)
  Enabled the SPIFFS. Fixed the HttpServer_Bootstrap example. (SmingHub#827)
  Added onDelivery callback for messages with QoS 1 or 2. (SmingHub#617)
  Backported changes from SmingRTOS. (SmingHub#825)
  Add FAST GPIO for CS pin and change pin numbering to start from 0 in MCP23S17 Lib (SmingHub#823)
  Fix issue SmingHub#709. Keep SPI_WR_BYTE_ORDER, SPI_RD_BYTE_ORDER, and SPI_CK_OUT_EDGE when upddating the SPI_USER reg (SmingHub#710)
  Fix stability and performance of websocket server (SmingHub#824)
  Fixed the SSL support for MQTT.
  Fixed Echo_Ssl sample.
  Feature/websocket client ssl (SmingHub#819)
  The latest spiffs is loaded as third-party module. (SmingHub#816)
  More efficient way to analyze errors. (SmingHub#821)
  Websocket client implementation for Sming (SmingHub#809)
  Simplified the compilation of custom PWM and Basic_HwPWM sample. (SmingHub#818)
  Removed test that is randomly braking on MacOS X travis machines.
  Adds / updates API documentation for: DateTime, Clock, Debug, NtpCient, RTC, SystemClock, some non-Sming (ESP) functions. (SmingHub#812)
  Fix/remove gdbstub (SmingHub#811)
  Fixes/freebsd (SmingHub#810)
  Proper timeout handling for Websockets (SmingHub#806)
  Added information about the SSL support. Fixed small typos.
  ...

# Conflicts:
#	Sming/Makefile-project.mk
johndoe8967 added a commit to johndoe8967/Sming that referenced this issue Dec 10, 2016
@johndoe8967
Merge branch 'upstream_develop' into Astro
24d1a33 
* upstream_develop: (43 commits)
  Added crash handler. Fixed/improved debugging information. (SmingHub#826)
  Enabled the SPIFFS. Fixed the HttpServer_Bootstrap example. (SmingHub#827)
  Added onDelivery callback for messages with QoS 1 or 2. (SmingHub#617)
  Backported changes from SmingRTOS. (SmingHub#825)
  Add FAST GPIO for CS pin and change pin numbering to start from 0 in MCP23S17 Lib (SmingHub#823)
  Fix issue SmingHub#709. Keep SPI_WR_BYTE_ORDER, SPI_RD_BYTE_ORDER, and SPI_CK_OUT_EDGE when upddating the SPI_USER reg (SmingHub#710)
  Fix stability and performance of websocket server (SmingHub#824)
  Fixed the SSL support for MQTT.
  Fixed Echo_Ssl sample.
  Feature/websocket client ssl (SmingHub#819)
  The latest spiffs is loaded as third-party module. (SmingHub#816)
  More efficient way to analyze errors. (SmingHub#821)
  Websocket client implementation for Sming (SmingHub#809)
  Simplified the compilation of custom PWM and Basic_HwPWM sample. (SmingHub#818)
  Removed test that is randomly braking on MacOS X travis machines.
  Adds / updates API documentation for: DateTime, Clock, Debug, NtpCient, RTC, SystemClock, some non-Sming (ESP) functions. (SmingHub#812)
  Fix/remove gdbstub (SmingHub#811)
  Fixes/freebsd (SmingHub#810)
  Proper timeout handling for Websockets (SmingHub#806)
  Added information about the SSL support. Fixed small typos.
  ...

# Conflicts:
#	Sming/Makefile-project.mk
#	Sming/SmingCore/Network/HttpServer.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slaff @harry-boe @hreintke @mtavenrath