Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software watchdog bites due to PR#1097 - m_printf: stacksize reduced #1274

Closed
frankdownunder opened this issue Nov 1, 2017 · 3 comments
Closed

Comments

@frankdownunder
Copy link
Contributor

If I use the old version of Sming/system/m_printf.cpp my code works fine. With the new version introduced on Sep 30, the dog bites me.
Two conclusions are possible:

  1. My code is making unreasonable demands
  2. The new version of m_printf.cpp is slower then the old version, possibly even a forever loop.

I suspect the second reason, and will do some timing tests and so on to investigate further.

@slaff
Copy link
Contributor

slaff commented Nov 8, 2017

There is definitely something fishy with the latest changes to m_printf.cpp ed94fb7. Reverting those changes made the Basic_Serial example work again with SDK 2.1+.

@frankdownunder Did you have time to analyze the changes?

@frankdownunder
Copy link
Contributor Author

@slaff Hi, I found nothing conclusive. I was hoping for a minimal "this demonstrates the bug" but couldn't. The new function didn't seem to be significantly slower either. I am fighting other fires now, sorry..

slaff pushed a commit to slaff/Sming that referenced this issue Nov 8, 2017
Was causing instability probably due to infinite loop.
Related to SmingHub#1274.
slaff added a commit that referenced this issue Nov 8, 2017
Was causing instability probably due to infinite loop.
Related to #1274.
mschader pushed a commit to mschader/Sming that referenced this issue Nov 8, 2017
Was causing instability probably due to infinite loop.
Related to SmingHub#1274.
@slaff
Copy link
Contributor

slaff commented Nov 9, 2017

@frankdownunder Feel free to reopen the ticket when you have more information about it.

@slaff slaff closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants