Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoWire::begin has reversed parameter order than on ESP8266/Arduino #1179

Closed
luelista opened this issue Jul 12, 2017 · 4 comments
Closed

TwoWire::begin has reversed parameter order than on ESP8266/Arduino #1179

luelista opened this issue Jul 12, 2017 · 4 comments
Milestone

Comments

@luelista
Copy link
Contributor

luelista commented Jul 12, 2017

I just spent a few hours debugging a small program I ported from ESP8266/Arduino to Sming. The problem was that I called Wire.begin(scl, sda); as it works on the Arduino implementation. On Sming, the order of params is reversed: Wire.begin(sda, scl);

I'm not sure if this should be changed here or there, but I'd at least like to put this here as a warning for other people searching for problems with I2C on Sming.

@zgoda
Copy link
Contributor

zgoda commented Jul 13, 2017

I remember we discussed this before. @avr39-ripe @slaff any opinion on this?

@avr39-ripe
Copy link
Contributor

I think we should make Wire.begin the same as ESP8266/Arduino. Update Wire implementation and update examples app.

@slaff
Copy link
Contributor

slaff commented Jul 13, 2017

I think we should make Wire.begin the same as ESP8266/Arduino. Update Wire implementation and update examples app.

@avr39-ripe Agreed. Can you create a new PR?

slaff pushed a commit to slaff/Sming that referenced this issue Jul 18, 2017
…Wire.pins parameters to

match the [Arduino order](samples/DS3232RTC_NTP_Setter/app/application.cpp).

Related to SmingHub#1179 and SmingHub#1061.

Warning: this is a backward incompatible change.
@slaff slaff added this to the 3.4.0 milestone Jul 21, 2017
slaff added a commit that referenced this issue Jul 27, 2017
…Wire.pins parameters to (#1193)

match the [Arduino order](samples/DS3232RTC_NTP_Setter/app/application.cpp).

Related to #1179 and #1061.

Warning: this is a backward incompatible change.
@slaff
Copy link
Contributor

slaff commented Jul 27, 2017

Should be fixed with PR #1193 which is merged now in the develop branch.

@slaff slaff closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants