-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TwoWire::begin has reversed parameter order than on ESP8266/Arduino #1179
Comments
I remember we discussed this before. @avr39-ripe @slaff any opinion on this? |
I think we should make Wire.begin the same as ESP8266/Arduino. Update Wire implementation and update examples app. |
@avr39-ripe Agreed. Can you create a new PR? |
…Wire.pins parameters to match the [Arduino order](samples/DS3232RTC_NTP_Setter/app/application.cpp). Related to SmingHub#1179 and SmingHub#1061. Warning: this is a backward incompatible change.
Should be fixed with PR #1193 which is merged now in the |
I just spent a few hours debugging a small program I ported from ESP8266/Arduino to Sming. The problem was that I called
Wire.begin(scl, sda);
as it works on the Arduino implementation. On Sming, the order of params is reversed:Wire.begin(sda, scl);
I'm not sure if this should be changed here or there, but I'd at least like to put this here as a warning for other people searching for problems with I2C on Sming.
The text was updated successfully, but these errors were encountered: