Fix codacy advisories

SmingHub · Feb 7, 2023 · ecea01b · ecea01b
1 parent 4c0a791
commit ecea01b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Sming/Arch/Esp32/Components/driver/hw_timer.cpp b/Sming/Arch/Esp32/Components/driver/hw_timer.cpp
@@ -176,10 +176,10 @@ class TimerConfig
 	timer_group_t group;
 	timer_idx_t index;
 	timg_dev_t* dev;
-	intr_handle_t isr_handle;
-	hw_timer_callback_t callback;
-	void* arg;
-	bool autoload;
+	intr_handle_t isr_handle{};
+	hw_timer_callback_t callback{nullptr};
+	void* arg{nullptr};
+	bool autoload{false};
 };
 
 TimerConfig timer(HW_TIMER1_GROUP, HW_TIMER1_INDEX);

diff --git a/Sming/Arch/Esp32/Tools/idf_tools.py b/Sming/Arch/Esp32/Tools/idf_tools.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python
 
-import os, sys, argparse, json
+import os, argparse, json
 
 def get_tool_info(soc):
     path = os.path.expandvars('${IDF_PATH}/tools/tools.json')

diff --git a/Tools/boardtool.py b/Tools/boardtool.py
@@ -306,10 +306,10 @@ def generate_pinmenu(args):
             f'    bool "{per.name}"',
             f'    default y',
         ]
-        help = per.help()
-        if help:
+        help_items = per.help()
+        if help_items:
             menu += ['    help']
-            menu += [f'      {s}' for  s in help]
+            menu += [f'      {s}' for  s in help_items]
         if per.swap:
             menu += [
                 f'  config PERIPH_{per.name}_SWAP_ENABLE',