Fix issues reported by valgrind (#2017)

* Fix issues with debug statements whilst running exit handlers * Fix issue with `TcpConnection::checkSelfFree()` being called twice Reported in #2007 (comment) and #2016
SmingHub · Jan 6, 2020 · e96d46f · e96d46f
1 parent ca120a3
commit e96d46f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Sming/Arch/Host/Components/hostlib/startup.cpp b/Sming/Arch/Host/Components/hostlib/startup.cpp
@@ -255,5 +255,8 @@ int main(int argc, char* argv[])
 
 	pause(config.exitpause);
 
+	// Avoid issues with debug statements whilst running exit handlers
+	m_setPuts(nullptr);
+
 	return exitCode;
 }
diff --git a/Sming/Core/Network/TcpConnection.cpp b/Sming/Core/Network/TcpConnection.cpp
@@ -499,12 +499,11 @@ err_t TcpConnection::staticOnPoll(void* arg, tcp_pcb* tcp)
 
 err_t TcpConnection::internalOnPoll()
 {
-	//if (tcp->state != ESTABLISHED)
-	//	return ERR_OK;
-
 	sleep++;
 	err_t res = onPoll();
-	checkSelfFree();
+	if(res == ERR_OK) {
+		checkSelfFree();
+	}
 	debug_tcp_ext("<poll");
 	return res;
 }