Override onHttpError rather than tcp onError

SmingHub · Mar 25, 2024 · b833ffb · b833ffb
1 parent d15afb6
commit b833ffb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Sming/Components/Network/src/Network/Http/HttpClientConnection.cpp b/Sming/Components/Network/src/Network/Http/HttpClientConnection.cpp
@@ -61,18 +61,20 @@ void HttpClientConnection::reset()
 	HttpConnection::reset();
 }
 
-void HttpClientConnection::onError(err_t err)
+bool HttpClientConnection::onHttpError(HttpError error)
 {
-	HttpConnection::onError(err);
+	bool res = HttpConnection::onHttpError(error);
 
-	auto request = waitingQueue.peek();
+	auto request = executionQueue.peek();
 
 	if(request != nullptr) {
 		auto callback = request->requestCompletedDelegate;
 		if(callback) {
 			callback(*this, false);
 		}
 	}
+
+	return res;
 }
 
 int HttpClientConnection::onMessageBegin(http_parser* parser)

diff --git a/Sming/Components/Network/src/Network/Http/HttpClientConnection.h b/Sming/Components/Network/src/Network/Http/HttpClientConnection.h
@@ -59,6 +59,9 @@ class HttpClientConnection : public HttpConnection
 	}
 
 protected:
+	// HttpConnection methods
+	bool onHttpError(HttpError error) override;
+
 	// HTTP parser methods
 
 	int onMessageBegin(http_parser* parser) override;
@@ -68,7 +71,6 @@ class HttpClientConnection : public HttpConnection
 
 	// TCP methods
 	void onReadyToSendData(TcpConnectionEvent sourceEvent) override;
-	void onError(err_t err) override;
 
 	void onClosed() override;