Improve sortOrder direction fallback in case of empty string #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when direction is an empty string, no results will be display in preview due to in error in the call to elastic:
```
{"error":{"root_cause":[{"type":"x_content_parse_exception","reason":"[1:50] [field_sort] failed to parse field [order]"}],"type":"x_content_parse_exception","reason":"[1:50] [field_sort] failed to parse field [order]","caused_by":{"type":"illegal_argument_exception","reason":"No enum constant org.elasticsearch.search.sort.SortOrder."}},"status":400}
```
|
Hi @frank-bokdam this is a good guard function, but in which case could this parameter be empty ? and by the way, I thought the getParam() second parameter was intended to be a fallback for such cases ? Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when direction is an empty string, no results will be display in preview due to in error in the call to elastic: