Allow using values from config.xml #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many settings in this module lack a 'use system value' or 'use default value' check-boxes. There are suitable settings in
etc/config.xmlfor these, but the same values are being set in thecore_config_datatable in the database unnecessarily, especially when changing only one value at a store view to also have all settings copied / overridden at that scope. This is misleading when later changing a value at a parent scope as the value at the more specific scope won't change too.This pull request fixes this problem by allowing these values to be inherited normally.
https://devdocs.magento.com/guides/v2.4/config-guide/prod/config-reference-systemxml.html#field-attribute-reference