Make elasticsuite use the dummy data provider for search suggestions #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for fixing the issue where a fatal error is thrown on catalogsearch result page on Magento 2.1 EE with
module-advanced-searchis enabled.This bug affects the "standard" search result page.
I think this is better to fix it on our side by just declaring a dummy (the default one which does nothing) data provider for search suggestions, instead of asking people to simply shut down the Advanced Search module.
=> It's easier for people to not being forced to disable EE module when using our engine.
=> This way, people can continue to use Advanced Search features like Recommendations (even if it is a perf killer, they have the choice to use it if they want).
=> We will be able to switch to our custom implementation later without having to say to people "ok now you can re-active module-advanced-search".
Let me know