-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Suite 2.2.x Magento 2.1 Custom Theme compatibility issue. #91
Comments
Hello, I had the same problem today with Porto. I have found the solution: In the file : Replace old with new variables: And reload your static-content: |
@DogSports So I fixed the _module.less file like you said and php bin/magento setup:static-content:deploy was a success Have you had or resolved this issue? |
The issue was the Theme was forcing the Default Search Block. Issue Fixed. |
@acidreian666 The issue was the Theme was forcing the Default Search Block. Issue Fixed. and how did you fixed?? What file did you change? |
I also would like to know how u fixed it. Any update on this? |
Hi there, I'm using Magento 2.1.4, Porto Theme same as @DogSports and their solution fixed my compilation problem. However, autocomplete results are not showing up properly, only as text, and not clickable. When I switch over to Luma, result is as expected. @acidreian666 @quisse could you please give a little more information on your solutions? Thanks |
@dharake I've added this file to my custom theme
with following content: <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
<body>
<referenceContainer name="porto_header">
<block class="Smile\ElasticsuiteCore\Block\Search\Form\Autocomplete" name="top.search" as="topSearch" template="Smile_ElasticsuiteCore::search/form.mini.phtml"/>
</referenceContainer>
</body>
</page> |
@quisse Thanks for getting back to me on this. Trying out your solution, but no luck so far. Just to clarify, you are creating a new folder Magento_Search, or did you mean Magento_CatalogSearch? So far I am getting the following output: |
@quisse Thanks again for the help, in my case I have solved the issue by modifying app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml Line 36 replaced: with
|
@dharake Yes, I've created Magento_Search (but i don't think this really matters) |
Hi, I am running into a very similar problem as @dharake @quisse and @acidreian666 where the search autocomplete results are not clickable, and no styles or images are showing in the search autocomplete results. @DogSports solution solved my earlier compilation problem with porto theme. I am using magento CE 2.1.7 elasticsuite 2.3, and porto 2.5.1. I have attempted @quisse solution by adding this file to my custom porto child theme in /app/design/frontend/Smartwave/custom ( i have also attempted this in /app/design/frontend/Smartwave/porto/) MyTheme/Magento_Search/layout/default.xml This did not not result in any changes. I have also edited /app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml by replacing with
However, the search autocomplete results are still not clickable and images are not showing. I have read that there is a possibility of the form.mini.phtml template being overridden elsewhere in the theme or parent theme files, but I have yet to locate that in porto theme. It is very clear from /app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml file that porto is removing the header-wrapper which smile elasticsuite seems to depend on. I have been struggling with this for quite some time. Any help or advice would be greatly appreciated, especially from anyone who can provide specific instructions on how to make this extension work with Porto theme. I am sure many will run into this issue as almost everyone uses a custom theme! Thank you! I look forward to successfully installing this great module! |
Hi @Mjato, will send you the solution in the morning. I'm running latest
magento and Porto, hope you can hold out until then. :)
…On 18 Jul 2017 9:37 pm, "mjamato714" ***@***.***> wrote:
Hi, I am running into a very similar problem as @dharake
<https://github.com/dharake> @quisse <https://github.com/quisse> and
@acidreian666 <https://github.com/acidreian666> where the search
autocomplete results are not clickable, and no styles or images are showing
in the search autocomplete results. @DogSports
<https://github.com/dogsports> solution solved my earlier compilation
problem with porto theme.
I am using magento CE 2.1.7 elasticsuite 2.3, and porto 2.5.1.
I have attempted @quisse <https://github.com/quisse> solution by adding
this file to my custom porto child theme in /app/design/frontend/
Smartwave/custom
( i have also attempted this in /app/design/frontend/Smartwave/porto/)
MyTheme/Magento_Search/layout/default.xml
with following content:
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:View/
Layout/etc/page_configuration.xsd"> <body> <referenceContainer
name="porto_header"> <block class="Smile\ElasticsuiteCore\
Block\Search\Form\Autocomplete" name="top.search" as="topSearch"
template="Smile_ElasticsuiteCore::search/form.mini.phtml"/>
</referenceContainer> </body> </page>
This did not not result in any changes.
I have also edited /app/design/frontend/Smartwave/porto/Smartwave_
Porto/layout/default.xml
by replacing
<block class="Magento\Framework\View\Element\Template" name="top.search"
as="topSearch" template="Magento_Search::form.mini.phtml" />
with
<block class="Smile\ElasticsuiteCore\Block\Search\Form\Autocomplete"
name="top.search" as="topSearch" template="Smile_
ElasticsuiteCore::search/form.mini.phtml"/>
However, the search autocomplete results are still not clickable and
images are not showing.
I have read that there is a possibility of the form.mini.phtml template
being overridden elsewhere in the theme or parent theme files, but I have
yet to locate that in porto theme.
It is very clear from /app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml
file that porto is removing the header-wrapper which smile elasticsuite
seems to depend on.
I have been struggling with this for quite some time. Any help or advice
would be greatly appreciated, especially from anyone who can provide
specific instructions on how to make this extension work with Porto theme.
I am sure many will run into this issue as almost everyone uses a custom
theme!
Thank you! I look forward to successfully installing this great module!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV1NbV6aTqNw-lgHYYAHyttlBI_vj0Fjks5sPPtcgaJpZM4JenYV>
.
|
Thanks a lot! @dharake |
Good morning @mjamato714 . So to resolve this issue, please perform the step as I described in the previous post 9th May. At this point, if you run
Therein lies the remaining issue. To resolve that we need to edit classes in the file /var/www/html/magento2/app/design/frontend/Smartwave/porto/Magento_CatalogSearch/web/css/source/module.less Replace the lines 6-10 with the following: You then need to go through the file and replace the old classes with these new ones. Once you save the changes, flush the cache, rerun In summary, the only 2 files that need to be modified are app/design/frontend/Smartwave/porto/Magento_CatalogSearch/web/css/source/module.less & app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml. N.B. If you want all the errors to disappear when deploying content, you must also replace the classes in the corresponding file for porto RTL folder. I hope that resolves your issue. |
Thank you very much @dharake for a great summary of these steps. I have edited the two files: While I am no longer getting any errors from php bin/magento setup:static-cotent:deploy, the search autocomplete still seems to be picking up the Magento's Default implementation of item.phtml which uses li tags. Here is what I am seeing in my browser console:
Did you have to implement @quisse 's solution in addition to the steps you have described? Another question I have is do you have smartwave megamenu enabled? I am wondering if this could be interfering somehow. Thank you again for your help. |
Hi @dharake After modifying files i am getting these errors
Could you please help me. |
Hi @suryawomshi, |
Hi, @tanolalano |
Hi there, |
@dharake , Thanks for the reply, I thought i am doing something wrong. Yes i am running 2.1.8 with Porto 2.6. Regards |
Yes, as you can see from the output, the error here is occuring in the blank theme, and Porto. So I think it's a magento version compatibility issue but I am not sure. @afoucret maybe can help? |
@dharake, |
Ah fantastic! Yes if you can post the changes that would be amazing. For your remaining issue that is easy. You need to change the z-index in css for the menu to have a lower value than the autocomplete results. Example: Replace the example class with the actual class. Try in chrome inspector and keep raising the value until the autocomplete appears over the menu. |
Hi @dharake Below steps will achieve working result Reset Theme Files (whatever we had modified as above) @autocomplete__background-color: @Color-White; In magento\app\design\frontend\Smartwave\porto\Magento_CatalogSearch\web\css\source_module.less upgrade, clean & flush cache, compile, content-deploy Check In Luma Theme, Switch Theme Clean Cache thats it. Let me know if it is working for you. |
In my Live server, the search contents are not clickable, I can see the search response is proper. |
Most certainly related to : In app/design/frontend/Smartwave/porto/Smartwave_Porto/layout/default.xml.
|
Hi @suryawomshi , I ran into the issue you are having with autocomplete results not showing properly and are not clickable. My solution is discussed in this thread: #477 The only difference for you may be the referenceContainer name depending on your theme/ desired position on layout. Let me know if you have any other questions regarding this and best of luck! |
I was reading issue you had discussed, while you posted here, yes you were right I had replace this with this Search terms Smile_ElasticsuiteCore/autocomplete/termand add this Products Smile_ElasticsuiteCatalog/autocomplete/product Categories Smile_ElasticsuiteCatalog/autocomplete/category Attributes Smile_ElasticsuiteCore/autocomplete/term Smile_ElasticsuiteCatalog/js/autocomplete/product-attribute**in this file ** Thanks a ton to you and @dharake |
For those also having Porto issues you may wish to see the ticket (and solution) I raised and closed here :#1112 |
…-boolean-no-value [2.8.x] ESP-296 Handle boolean no value
Installed fresh copy of Magento 2.1 with elasticsuite 2.2.x
Fully Functional 2.1 with Elastic suite working correctly.
Preconditions
Steps to reproduce
php bin/magento setup:upgrade
php bin/magento setup:di:compile
php bin/magento setup:static-content:deploy
Expected result
Actual result
3.
I know this issue is known and that's the reason for using the 2.2.x version to begin using Elastic Suite but before i go complaining to the Theme dev I wanted to see what Team-Smile has to say.
Also for dev purposes i can supply a custom them for your trouble shooting.
The text was updated successfully, but these errors were encountered: