Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dates attributes in the rule engine #3256

Closed
romainruaud opened this issue Apr 17, 2024 · 0 comments
Closed

Allow dates attributes in the rule engine #3256

romainruaud opened this issue Apr 17, 2024 · 0 comments
Assignees
Labels

Comments

@romainruaud
Copy link
Collaborator

romainruaud commented Apr 17, 2024

The rule engine should be able to support dates attributes (like created_at, updated_at).

Actually, if I configure one of these attributes as "Used for promo rules = Yes", I can see them in the rule engine when creating a virtual category, but selecting them triggers the following error :

[2024-04-18T07:21:52.492644+00:00] main.ERROR: Deprecated Functionality: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /var/www/html/vendor/magento/module-rule/Model/Condition/AbstractCondition.php on line 684 [] []

There should not be any error, and we should be able to select a date as value with a date picker.

Of course, the resulting query should work.

@romainruaud romainruaud assigned romainruaud and vahonc and unassigned romainruaud Apr 17, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue May 9, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue May 9, 2024
romainruaud added a commit that referenced this issue Jun 3, 2024
…le-engine

Feature #3256, allow date attributes in the rule engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants