Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models #7

Merged
merged 32 commits into from
May 19, 2024
Merged

Models #7

merged 32 commits into from
May 19, 2024

Conversation

Smartappli
Copy link
Owner

@Smartappli Smartappli commented May 19, 2024

Summary by CodeRabbit

  • New Features

    • Introduced GitHub issue templates for bug reports, feature requests, and questions to streamline user feedback.
    • Added a template for creating Sweep issues, managed by an AI-powered junior developer.
    • Added GitHub funding information for the organization.
  • Enhancements

    • Updated the Dependabot configuration to run daily updates and added labels for package ecosystems.
    • Introduced a release drafter tool for better release management with automated versioning and categorization.
  • Documentation

    • Updated README to include new models: "Gorilla 7B-Falcon, 7B, OpenFunctions V1, OpenFunctions V2."
  • Bug Fixes

    • Improved readability of assertion statements in tests.
  • Chores

    • Added a new code owner for better code management.
    • Introduced GitHub Actions workflows for code formatting and model checks.

Copy link

sweep-ai bot commented May 19, 2024

Sweep: PR Review

.github/CODEOWNERS

The change adds @Smartappli as a code owner in the .github/CODEOWNERS file.


.github/FUNDING.yml

The change adds a GitHub sponsor handle to the funding configuration file.


.github/ISSUE_TEMPLATE/bug-report.yml

A new bug report template has been added with fields for description, steps to reproduce, environment information, optional screenshots, relevant logs, and confirmations.


.github/ISSUE_TEMPLATE/feature-request.yml

A new feature request issue template has been added to the GitHub repository.


.github/ISSUE_TEMPLATE/question.yml

A new issue template for questions has been added, including fields for a detailed description and a checklist to ensure proper issue submission.


.github/ISSUE_TEMPLATE/sweep-template.yml

A new issue template for reporting small bugs, features, refactors, and tests to be handled by Sweep has been added.


.github/dependabot.yml

The pull request modifies the update schedule for GitHub Actions to daily and adds new daily update configurations for "pip" and "docker" with a "🤖 Dependencies" label.

Sweep Found These Issues

  • Changing the update interval to daily for GitHub Actions, pip, and docker may lead to an increased number of pull requests, potentially overwhelming the team and causing integration issues.
  • interval: "daily"
    labels:
    - "🤖 Dependencies"
    - package-ecosystem: "pip"
    directory: "/"
    schedule:
    interval: "daily"
    labels:
    - "🤖 Dependencies"
    - package-ecosystem: "docker"
    directory: "/"
    schedule:
    interval: "daily"

    View Diff


.github/release-drafter.yml

The changes add a comprehensive configuration for the Release Drafter GitHub Action, including templates, categories, version resolution, and auto-labeling rules.

Sweep Found These Issues

  • The version-resolver section includes the label '❗ Breaking Change' under both minor and major categories, which could lead to inconsistent versioning.
  • - 'major'
    minor:
    labels:
    - 'minor'
    - '❗ Breaking Change'
    - '✏️ Feature'

    View Diff


.github/workflows/black.yml

A new GitHub Actions workflow is added to automatically format Python code using the Black formatter and create a pull request if formatting changes are detected.


.github/workflows/model-check.yml

Added concurrency control to the GitHub Actions workflow to prevent multiple instances from running simultaneously.


.github/workflows/ruff.yml

The pull request adds a new GitHub Actions workflow to automate code linting with Ruff, ignoring F401 errors and automatically fixing issues.

Sweep Found These Issues


README.md

The README.md file was updated to include new models in the "All" category of supported models.


all/models.json

The pull request removes the "Asclepius" category and adds new categories "Gorilla," "LLaMA_3," "Meta-Llama-3," "OpenCodeInterpreter," and a new model to the "Wizard" category, expanding the dataset with additional models and their metadata.

Sweep Found These Issues

  • The removal of the "Asclepius" category and its associated model "Asclepius-13B" could impact any functionality relying on this specific model.
  • "name": "Asclepius",
    "models": [
    {
    "name": "Asclepius-13B",
    "repo": "TheBloke/Asclepius-13B-GGUF",
    "files": [
    {
    "name": "q4_K_M",
    "filename": "asclepius-13b.Q4_K_M.gguf",
    "disk_space": 7865956256.0
    }
    ]
    }
    ]
    },

    View Diff


test.py

The changes include adding a trailing comma to the model_paths list and reformatting the assert statement in the test_model_available function for better readability.


Copy link

coderabbitai bot commented May 19, 2024

Warning

Rate Limit Exceeded

@Smartappli has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 57 minutes and 32 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 0db9488 and 1673bbe.

Walkthrough

The recent changes bring a wave of enhancements to the project's GitHub repository. New issue templates for bugs, features, and questions have been added, along with a template for AI-powered issue handling. GitHub funding details and code ownership were updated, while workflows for code formatting and linting were introduced. Model listings were revised, and a release drafter configuration was included.

Changes

File/Path Change Summary
.github/CODEOWNERS Added @Smartappli as a code owner.
.github/FUNDING.yml Introduced GitHub funding information for the organization "Smartappli."
.github/ISSUE_TEMPLATE/bug-report.yml Added a detailed bug report template.
.github/ISSUE_TEMPLATE/feature-request.yml Included a template for suggesting feature improvements.
.github/ISSUE_TEMPLATE/question.yml Added a structured template for user questions.
.github/ISSUE_TEMPLATE/sweep-template.yml Introduced a template for handling small tasks with an AI assistant.
.github/dependabot.yml Updated update schedules to run daily and added labels for package ecosystems.
.github/release-drafter.yml Added configuration settings for a release drafter tool.
.github/workflows/black.yml Introduced a workflow for running the Black code formatter.
.github/workflows/model-check.yml Added a concurrency configuration for the model-check workflow.
.github/workflows/ruff.yml Included a workflow for running the Ruff linter.
README.md Added "Gorilla 7B-Falcon, 7B, OpenFunctions V1, OpenFunctions V2" to the list of models.
all/models.json Updated entities and models, removing "Asclepius" and adding new entities like "Gorilla," "LLaMA_3," etc.
test.py Improved readability of the assertion statement in the test_model_available function.

In the land of code, where changes bloom,
New templates arise, dispelling gloom.
With workflows that check and format with grace,
And models that find their rightful place.
Funding and owners, all set anew,
The project's future, bright and true. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f93f3a9 and 8d9e6af.
Files selected for processing (14)
  • .github/CODEOWNERS (1 hunks)
  • .github/FUNDING.yml (1 hunks)
  • .github/ISSUE_TEMPLATE/bug-report.yml (1 hunks)
  • .github/ISSUE_TEMPLATE/feature-request.yml (1 hunks)
  • .github/ISSUE_TEMPLATE/question.yml (1 hunks)
  • .github/ISSUE_TEMPLATE/sweep-template.yml (1 hunks)
  • .github/dependabot.yml (1 hunks)
  • .github/release-drafter.yml (1 hunks)
  • .github/workflows/black.yml (1 hunks)
  • .github/workflows/model-check.yml (1 hunks)
  • .github/workflows/ruff.yml (1 hunks)
  • README.md (1 hunks)
  • all/models.json (6 hunks)
  • test.py (1 hunks)
Files skipped from review due to trivial changes (10)
  • .github/CODEOWNERS
  • .github/FUNDING.yml
  • .github/ISSUE_TEMPLATE/bug-report.yml
  • .github/ISSUE_TEMPLATE/question.yml
  • .github/ISSUE_TEMPLATE/sweep-template.yml
  • .github/dependabot.yml
  • .github/workflows/black.yml
  • .github/workflows/model-check.yml
  • .github/workflows/ruff.yml
  • test.py
Additional comments not posted (17)
.github/ISSUE_TEMPLATE/feature-request.yml (5)

1-4: LGTM! The metadata for the feature request template is clear and well-defined.


6-13: Well-structured notice section. It effectively guides users on where to ask questions and how to choose the correct template.


14-21: The feature description section is comprehensive and clearly requires detailed input, which is great for capturing essential details about the feature request.


22-28: The additional context section is optional and well-designed to capture any extra information that might be relevant to the feature request.


28-37: The checklist ensures that users have performed due diligence before submitting the feature request. It promotes quality and relevance in submissions.

.github/release-drafter.yml (6)

1-2: The version naming and tagging templates are set to use resolved version numbers, which should streamline the release process.


3-21: The categorization of changes is comprehensive, covering all necessary aspects like new features, bug fixes, and documentation updates. This should help in organizing the release notes effectively.


22-23: The change template and title escapes are well-configured to ensure clarity in the release notes.


24-43: Excluding bots like dependabot from contributors list and detailed version resolver settings are good practices to maintain clean and relevant release notes.


44-53: The release template is well-structured, providing placeholders for changes, Docker images, and a full changelog link. It also appreciates contributors, which is a nice touch.


55-72: The autolabeler settings are thoughtfully configured to automatically label pull requests based on the content, which should help in managing the project's workflow.

README.md (1)

20-20: The addition of new models under the "All" category is well-documented. Ensure all newly listed models are correctly linked and accessible.

Verification successful

The README.md file contains several markdown links, but none of them are related to the newly added models. Therefore, there are no broken links to verify for the newly listed models.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that all newly listed models are correctly linked and accessible.

# Test: Check for broken links in the README.md file.
rg --type markdown $'\\[.*\\]\\(.*\\)' README.md | xargs -n 1 curl -o /dev/null --silent --head --fail

Length of output: 281



Script:

#!/bin/bash
# Description: Verify that all newly listed models are correctly linked and accessible.

# Test: Check for broken links in the README.md file.
rg --type markdown '\[.*\]\(.*\)' README.md | grep -oP '\(http.*?\)' | tr -d '()' | xargs -n 1 curl -o /dev/null --silent --head --fail

Length of output: 137



Script:

#!/bin/bash
# Description: Check if the README.md file contains any markdown links.

# Search for markdown links in the README.md file.
rg '\[.*\]\(.*\)' README.md

Length of output: 678

all/models.json (5)

351-398: Added new entity "Gorilla" with several models.

This addition aligns with the PR's objective to update the model listings. The JSON structure is correctly maintained, and the disk space values are provided for each file, which is consistent with the rest of the entries.


493-528: Added new entity "LLaMA_3" with several models.

The addition of "LLaMA_3" with detailed model configurations is consistent with the existing structure of the JSON file. Each model entry includes the necessary details such as repository and disk space, which is crucial for maintaining data integrity.


666-712: Added new entity "Meta-Llama-3" with several models.

The new "Meta-Llama-3" entity has been added with multiple model configurations. The JSON entries are well-formed, and the disk space for each model is specified, ensuring consistency with the rest of the model entries.


920-977: Added new entity "OpenCodeInterpreter" with several models.

The addition of the "OpenCodeInterpreter" entity with detailed model configurations is consistent with the existing structure of the JSON file. Each model entry includes the necessary details such as repository and disk space, which is crucial for maintaining data integrity.


1313-1321: Added new model "WizardLM-2-7B" under the "Wizard" entity.

The addition of the "WizardLM-2-7B" model under the existing "Wizard" entity is correctly implemented. The JSON structure is maintained, and the disk space is specified, aligning with the format used throughout the document.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8d9e6af and 0db9488.
Files selected for processing (1)
  • .github/workflows/model-check.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/model-check.yml

@Smartappli Smartappli merged commit cf6af2f into main May 19, 2024
5 checks passed
@Smartappli Smartappli deleted the models branch May 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant