fix: minor st-schema invite updates #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb029e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sitlintac
approved these changes
Oct 26, 2023
| @@ -25,14 +25,11 @@ export type SchemaAppInvitation = SchemaAppId & { | |||
| description?: string | |||
| expiration?: number | |||
| acceptUrl?: string | |||
| acceptances: number | |||
There was a problem hiding this comment.
Just want to double-check that this is meant to be a mandatory property, like id, rather than optional like all the others.
There was a problem hiding this comment.
It's not officially in the docs but since it's always there I think we can assume required.
rossiam
force-pushed
the
schema-invites-cleanup
branch
from
f1dfb2e to
cb029e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acceptancesfieldgetAcceptanceStatusandacceptand related codeTypes of Changes
npm run lintproduces no warnings/errors)