Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: migrate to @oclif/core #238

Merged
merged 1 commit into from
Feb 9, 2022
Merged

perf: migrate to @oclif/core #238

merged 1 commit into from
Feb 9, 2022

Conversation

john-u
Copy link
Contributor

@john-u john-u commented Dec 30, 2021 •
edited
Loading

@john-u john-u mentioned this pull request Dec 30, 2021
Closed
@john-u john-u force-pushed the oclif-core branch 4 times, most recently from ad42d73 to c0a677c Compare February 8, 2022 21:34
john-u
john-u commented Feb 8, 2022
View reviewed changes
packages/cli/README.md Show resolved Hide resolved
packages/cli/README.md
@@ -233,1620 +232,2101 @@ get a specific app or a list of apps

```
USAGE
$ smartthings apps [ID]
$ smartthings apps [ID] [-h] [-p <value>] [-t <value>] [--language <value>] [--indent <value>] [-j] [-y]
[-o <value>] [--compact] [--expanded] [--type <value>] [--classification <value>] [-v]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to readme output are from migrating away from @oclif/dev-cli to oclif instead.

@john-u john-u marked this pull request as ready for review February 8, 2022 21:38
@john-u john-u changed the title refactor: migrate to @oclif/core perf: migrate to @oclif/core Feb 8, 2022
rossiam
rossiam approved these changes Feb 8, 2022
View reviewed changes
packages/cli/src/hooks/init/init-config.ts
@@ -1,4 +1,4 @@
import { Hook } from '@oclif/config'
import type { Hook } from '@oclif/core'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought I'd change this to a type-only import.

@john-u john-u merged commit 7354083 into SmartThingsCommunity:master Feb 9, 2022
@john-u john-u deleted the oclif-core branch February 17, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossiam rossiam rossiam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-u @rossiam