Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for different parity settings and YTL meter #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

arjanmels
Copy link
Contributor

@arjanmels arjanmels commented Nov 7, 2020

  • Added support for different parity settings for different meters
  • Added support for using modbus function code 3 in addition to 4
  • Added support for YTL DTS353F-2 kWh meter
  • Enabled MCLR pin (to allow resetting via ICD connector)
  • Fixed superfluous ;
  • Cleaned automatically generated files from repo
  • Added phase currents to display
  • Error detection for all meters
  • Display Connected for STATE_B

Copy link
Member

@mstegen mstegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Arjan,
I don't think this will work, as the config bytes are pre-set when flashing the controller for the first time, and should not be modified with the bootloader.
Also, as there is no external pull up on the MCLR line, setting it to external while noting is connected to the pin, can cause resets. (even with the internal weak pull up)

Copy link
Member

@mstegen mstegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@arjanmels
Copy link
Contributor Author

I don't think this will work, as the config bytes are pre-set when flashing the controller for the first time, and should not be modified with the bootloader.

You're right, I did a flash with a pickit to set this. It is not a must have as you can enter and exit bootloader via protocol. I added it because I was stuck once or twice in the bootloader during debugging (by faulty baudrate detection I guess.).

Also, as there is no external pull up on the MCLR line, setting it to external while noting is connected to the pin, can cause resets. (even with the internal weak pull up)

Ok, I had expected the internal pull-up to be sufficient.

I'll remove it in my next push. BTW still running some tests, hence the draft status.

- Fixed YTL byte order
- Added phase currents to display
- Error detection for all meters
- Display Connected for STATE_B
@arjanmels
Copy link
Contributor Author

Added further improvements and fixes and tested properly.

@arjanmels arjanmels marked this pull request as ready for review November 7, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants