Option to change increment on investments number fields (Issue 32)

[ricardopetrere]

As in #32, I've created a mechanism, exactly like in game, to change the increment of the investment amount fields. The values are 1, 10 and 100, changeable by clicking the "Buy" button below "Save State". (PS: Just like in game, when you change the world, it resets to 1)

[DarthMDev]

I added an option for +1000 in a pull request in your fork
Also can u add subtract 1, 10 ,100 and 1000

[61352151511]

The thing is, I don't see a point in this pull request, like I get the arrows are there to add and subtract, but if you're going to constantly use a button to toggle between +1, +10, +100, +1000 then you might as well just click in the investment box, backspace, and type the new number. It's really not that difficult to do that. If Slimmmo decides that this is a useful enough feature I suggest that the button is moved as right now it is fairly close to the "Hard Reset Planet" and that button may be pressed by accident

[DarthMDev]

@61352151511 this is useful for me espically since this would be faster for me then typing in because im a slow ipad typer

[ricardopetrere]

...Well, there's a lot here for me to answer...
First of all, @61352151511, haven't you or Slimmmo seen this PR in all these days? It's been open for 17 days, and only 4 days ago I got an answer. I'm sorry, but it's quite frustrating to wait this long for a feedback. You could say "I don't see a point in this pull request" earlier.
Second, I just made this request because issue 32 is still open, so I thought the idea was still valid and/or considered useful to the Calculator. If the issue was closed, I would've not made this PR.
Third, I actually placed the button as far as possible from the "Hard Reset Planet" (I just copied the placement from the "Save State" button), so the button would only be close if one is playing on mobile or on a screen with less than 1024 pixels width, which in both cases everything would be close to one another. But if it's still placing it wrong, then there's something I need to look after.

I'm really sorry if any of this seems offending or ranting or "he got it personal", they are just my opinions on the matter.

[61352151511]

Yes, I've read it. Not sure on Slimmmo's stance on it. I'm leaving it up to him on it but my personal opinion still lies at that it's not too useful. The argument made that its good for mobile (slow IPad typer specifically) is invalid from what I've seen because the up/down arrows aren't even present on the two tests I did (Moto G4 Android 6.0.1, iPad not sure the iOS) so all it would be useful for is PC and those users should just be able to type out the number.

However again, this PR is up to @Slimmmo

[dr-ishmael]

Speaking as a PC user, I would find this very helpful. Having to move my
hand back and forth between my mouse and the number pad on my keyboard
every time I want to update numbers outside of the recommendations table is
quite annoying. Being able to do that with just the mouse would be great.

On Fri, Aug 19, 2016 at 5:30 AM, Mitchell [email protected] wrote:

Yes, I've read it. Not sure on Slimmmo's stance on it. I'm leaving it up
to him on it but my personal opinion still lies at that it's not too
useful. The argument made that its good for mobile (slow IPad typer
specifically) is invalid from what I've seen because the up/down arrows
aren't even present on the two tests I did (Moto G4 Android 6.0.1, iPad not
sure the iOS) so all it would be useful for is PC and those users should
just be able to type out the number.

However again, this PR is up to @Slimmmo https://github.com/Slimmmo

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#87 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1w5-66OoTV_w92GC8xk4_d5R0fLkgeks5qhYWvgaJpZM4JaH0J
.

[DarthMDev]

Um @ricardopetrere can you fix it for mobile so the up/down arrows are present