Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use marker name for triggers; change spec to prepare for timestamp-range markers. #856

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

shueja
Copy link
Collaborator

@shueja shueja commented Oct 10, 2024

New Spec:
All markers in the events property of .traj root

{
   name: "used for triggers",
   from: {
      offset: Expression
      targetTimestamp: number // offset.val + targetTimestamp = marker timestamp
      target: WaypointIDX // ignored by libraries
    },
    to: { // same as from, reserved for later},
    event: {/*pplib command with waitTime an Expression*/} | null //markers can have no gui-attached command.
}

@shueja shueja marked this pull request as draft October 10, 2024 21:11
@shueja shueja marked this pull request as ready for review October 10, 2024 21:55
Copy link
Collaborator

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shueja shueja merged commit aa4a090 into SleipnirGroup:main Oct 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants